Home | Contact Us | FAQ | Search & Site Map | Link to Us
Sign In | Join | Other 45 Sites in Network
HomeAnnouncementsWhite Papers
Discussion GroupsFirst AidDatabasesJavaBeansGUIJava 3DVirtual MachineCORBASecurityToolsGeneral
Java DirectoryOpen Source ProjectsSample Book ChaptersUser GroupsWeb Resources
Related Topics
Databases.NETMore Topics ...

Java Forum / General / April 2007

Tip: Looking for answers? Try searching our database.

Generics/Comparator

Thread view: 
Kaiser S. - 24 Apr 2007 12:24 GMT
Hello,

here is a short class source with begining of generics. Could you please
tell me how to use generics with the comparators ?

import java.util.Comparator;
import java.util.TreeSet;

public class TestComparator {

    private static abstract class A {
    }
   
    private static class B extends A {
    }

    private static class C extends A {
    }
   
    private static abstract class HandlerOfA {
        public abstract Comparator getComparator();
    }
   
    private static class HandlerOfB extends HandlerOfA {
        public static class ComparatorOfB implements Comparator<B> {
           public int compare(B b1, B b2) {
               return 0;
           }

        }
        public Comparator getComparator() {
            return new ComparatorOfB();
        }
    }

    private static class HandlerOfC extends HandlerOfA {
        public static class ComparatorOfC implements Comparator<C> {
           public int compare(C c1, C c2) {
               return 0;
           }

        }
        public Comparator getComparator() {
            return new ComparatorOfC();
        }
    }
   
   
    public static void main(String[] args) {
        HandlerOfA contA = new HandlerOfB();
        HandlerOfB contB = new HandlerOfB();
        HandlerOfC contC = new HandlerOfC();
       
        TreeSet<A> treesetA = new TreeSet<A>(contA.getComparator());
        treesetA.add(new B());
       
        TreeSet<B> treesetB = new TreeSet<B>(contB.getComparator());
        treesetB.add(new B());

        TreeSet<C> treesetC = new TreeSet<C>(contC.getComparator());
        treesetC.add(new C());
       
    }
}

Thanks for any help
Kaiser S. - 25 Apr 2007 09:10 GMT
If it's not possible to put generics in comparators, could you tell me
what is wrong in the design of the classes? What should i change in
order to have the same fonctionnalities, but with a different design ?
Hendrik Maryns - 25 Apr 2007 10:58 GMT
Kaiser S. schreef:
> If it's not possible to put generics in comparators, could you tell me
> what is wrong in the design of the classes? What should i change in
> order to have the same fonctionnalities, but with a different design ?

Please quote some content if you reply to a message.  I now had to look
for you previous message in order to try to help.

I pasted it in below.

There is no problem using generics in comparators, but your design is,
indeed, flawed.  First of all, the semantics is unclear: why are
HandlerOfB and HandlerOfC extending HandlerOfA?

That is also the source of the problem: HandlerOfA defines
getComparator(), which returns a Comparator.  Here already you should
get a compiler warning not to use raw types.  But in respect to what
comes later, it is difficult to generify this.  What type of Comparator
would you return?  Comparator<A> won’t work, since then the methods in
HandlerOfB and HandlerOfC won’t override properly.  A possibility is to
make the method itself generic:

public abstract <T extends A> Comparator<T> getComparator();

But that would make it more complicated than it’s worth.  From the
snippet you show in the main method, I see no reason why you would need
the handlers inherit from each other.  So maybe if you explained what
you really wanted, someone could help you better.

Read also the last link in my sig, particularly the section ‘describe
the goal, not the step’.

> Hello,
>
[quoted text clipped - 59 lines]
>     }
> }

H.

- --
Hendrik Maryns
http://tcl.sfs.uni-tuebingen.de/~hendrik/
==================
http://aouw.org
Ask smart questions, get good answers:
http://www.catb.org/~esr/faqs/smart-questions.html
Kaiser S. - 25 Apr 2007 12:02 GMT
> There is no problem using generics in comparators, but your design is,
> indeed, flawed.  First of all, the semantics is unclear: why are
> HandlerOfB and HandlerOfC extending HandlerOfA?

Well the snippet is a simplified version of the real source code. The
Handlers have 10/15 methods in common and in a lot of places, i don't
need to know the actual type of handler.

> That is also the source of the problem: HandlerOfA defines
> getComparator(), which returns a Comparator.  Here already you should
[quoted text clipped - 7 lines]
>
> But that would make it more complicated than it’s worth.  From the

Yes, it's not possible to generify the method.

> snippet you show in the main method, I see no reason why you would need
> the handlers inherit from each other.  So maybe if you explained what
> you really wanted, someone could help you better.

>> import java.util.Comparator;
>> import java.util.TreeSet;
[quoted text clipped - 55 lines]
>>     }
>> }
Esmond Pitt - 26 Apr 2007 02:39 GMT
You need a few adjustments:

    private static abstract class HandlerOfA
    {
        public abstract Comparator<? extends A> getComparator();
    }
   
    private static class HandlerOfB extends HandlerOfA
    {
        public static class ComparatorOfB implements Comparator<B>
        {
            public int compare(B b1, B b2)
            {
                return 0;
            }
        }
        public Comparator<B> getComparator()
        {
            return new ComparatorOfB();
        }
    }
   
    private static class HandlerOfC extends HandlerOfA
    {
        public static class ComparatorOfC implements Comparator<C>
        {
            public int compare(C c1, C c2)
            {
                return 0;
            }
           
        }
        public Comparator<C> getComparator()
        {
            return new ComparatorOfC();
        }
    }

and then in your main:
   
        HandlerOfA contA = new HandlerOfB();
       
        TreeSet<A> treesetA = new TreeSet<A>(contA.getComparator());

This ceases to make sense once the generics are introduced.


Free Magazines

Get these publications absolutely FREE for up to 12 months. There are no hidden fees and no obligation. Simply choose a title, complete the application form and submit it. Read more ...

Oracle MagazineNetwork ComputingComputer WorldBio-IT WorldeWeekInformation WeekInfosecurity
 
Sign In
Join
My Latest Posts
My Monitored Threads
My Blog
My Photo Gallery
My Profile
My Homepage

Start New Thread
Enable EMail Alerts
Rate this Thread



©2008 Advenet LLC   Privacy Policy - Terms of Use
This website includes both content owned or controlled by Advenet as well as content owned or controlled by third parties.