...
>this is the code i have written
Please read my original message again, carefully.
If there is anything that I did not make clear about
helping the reader, feel free to ask.
...
>in this case if i do not return some thing even in the case of
>throwing the exception, i have to retrn some value. otherwise the
>class wont compile.
I do not quite understand what the problem is. Your
code was almost there. Here is an example of code
that compiles, and runs..
<sscce>
class ReportObject implements Comparable {
int positionNumber;
ReportObject(int positionNumber) {
this.positionNumber = positionNumber;
}
public int compareTo(Object obj){
ReportObject rObj;
if(obj instanceof ReportObject ){
rObj = (ReportObject)obj;
if(this.positionNumber < rObj.getPositionNumber()){
return -1;
}else if(this.positionNumber == rObj.getPositionNumber()){
return 0;
}else if(this.positionNumber > rObj.getPositionNumber()){
return 1;
}
}else{
throw new ClassCastException(this +
" is not comparable to " + obj );
}
return -2;
}
public int getPositionNumber() {
return positionNumber;
}
public String toString() {
return "ReportObject: " + getPositionNumber();
}
public static void main(String[] args) {
ReportObject reportObject1 = new ReportObject(1);
ReportObject reportObject2 = new ReportObject(2);
Object object = new Object();
try {
System.out.println( reportObject2.compareTo(reportObject1) );
System.out.println( reportObject1.compareTo(reportObject2) );
System.out.println( reportObject2.compareTo(reportObject2) );
System.out.println( reportObject2.compareTo(object) );
} catch(ClassCastException cce) {
System.out.println( cce.getMessage() );
}
}
}
</sscce>
HTH

Signature
Andrew Thompson
http://www.athompson.info/andrew/
Hendrik Maryns - 23 Apr 2007 13:48 GMT
Andrew Thompson schreef:
> ..
>> this is the code i have written
[quoted text clipped - 26 lines]
> return -2;
> }
Funny, I would have expected a compiler error here about unreachable
code. The last line is unreachable, right?
Ah, no, it isn’t. At least, the compiler cannot know: obj can be an
instance of ReportObject, and the getPositionNumber() method can vary
such that none of the inner conditions fits.
Anyway, why not simply
public int compareTo(Object obj){
ReportObject rObj = (ReportObject)obj;
if(this.positionNumber < rObj.getPositionNumber()){
return -1;
}else if(this.positionNumber == rObj.getPositionNumber()){
return 0;
}else if(this.positionNumber > rObj.getPositionNumber()){
return 1;
}
}
The JVM will throw the ClassCastException, no need to do that yourself.
And oh yes, you might try to venture into generics, in which case the
problem will go away all by itself:
class ReportObject implements Comparable<? super ReportObject> {
...
public int compareTo(ReportObject obj){
if(this.positionNumber < obj.getPositionNumber()){
return -1;
}else if(this.positionNumber == obj.getPositionNumber()){
return 0;
}else if(this.positionNumber > obj.getPositionNumber()){
return 1;
}
}
...
}
H.
- --
Hendrik Maryns
http://tcl.sfs.uni-tuebingen.de/~hendrik/
==================
http://aouw.org
Ask smart questions, get good answers:
http://www.catb.org/~esr/faqs/smart-questions.html
Daniel Pitts - 23 Apr 2007 16:24 GMT
On Apr 23, 5:48 am, Hendrik Maryns <hendrik_mar...@despammed.com>
wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
[quoted text clipped - 76 lines]
>
> }
You might ALSO venture into using some basic logic.
if (a < b) {
return -1;
} else if (a > b) {
return 1;
}
return 0;
it is highly (100%) likely that if (!(a < b) && !(a > b)), then a ==
b. At least with primitive data types in Java.
Daniel Pitts - 23 Apr 2007 16:28 GMT
> On Apr 23, 5:48 am, Hendrik Maryns <hendrik_mar...@despammed.com>
> wrote:
[quoted text clipped - 91 lines]
> it is highly (100%) likely that if (!(a < b) && !(a > b)), then a ==
> b. At least with primitive data types in Java.
Actually, I think I'm wrong.
NaN isn't == NaN, is it?
In any case, comparable should throw an exception in that case too, as
you can't order NaN.
Actually, if you are using floating point values, you can use
Double.compareTo or Float.compareTo.
Indeed, I would probably do this:
public int compareTo(ReportObject obj) {
return Integer.compareTo(this.positionNumber,
obj.getPositionNumber());
}