Home | Contact Us | FAQ | Search & Site Map | Link to Us
Sign In | Join | Other 45 Sites in Network
HomeAnnouncementsWhite Papers
Discussion GroupsFirst AidDatabasesJavaBeansGUIJava 3DVirtual MachineCORBASecurityToolsGeneral
Java DirectoryOpen Source ProjectsSample Book ChaptersUser GroupsWeb Resources
Related Topics
Databases.NETMore Topics ...

Java Forum / General / April 2007

Tip: Looking for answers? Try searching our database.

Comparable interface

Thread view: 
Chanchal - 23 Apr 2007 07:27 GMT
hi ,
if i am implelenting the comparable interface, and the parameter
passed is not an object which is comparable to the calling object,
what value shall the function return. Or is there any otherway i
should handle that situation.

Kindly advice,

Thanks in advance..

Chanchal
Andrew Thompson - 23 Apr 2007 07:43 GMT
...
>if i am implelenting the comparable interface, and the parameter
>passed is not an object which is comparable to the calling object,
>what value shall the function return. Or is there any otherway i
>should handle that situation.

The code might throw an IllegalArgumentException or a ClassCastException.

Some other things you might do to help the *reader*, are to:
- Put a single upper case letter at the start of every sentence.
- Always write the word 'I' as upper case.
- Put a question mark (?) at the the end of questions.
- Capitalise core J2SE classes correctly (e.g. Comparable).

Signature

Andrew Thompson
http://www.athompson.info/andrew/

Chanchal - 23 Apr 2007 10:47 GMT
hello Andrew,

this is the code i have written

public int compareTo(Object obj){
        ReportObject rObj;
        if(obj instanceof ReportObject ){
            rObj = (ReportObject)obj;

            if(this.positionNumber < rObj.getPositionNumber()){
                return -1;
            }else if(this.positionNumber == rObj.getPositionNumber()){
                return 0;
            }else if(this.positionNumber > rObj.getPositionNumber()){
                return 1;
            }

        }else{
            throw new ClassCastException();

        }
        return -2;
    }

in this case if i do not return some thing even in the case of
throwing the exception, i have to retrn some value. otherwise the
class wont compile. i have returned a -2 in that case. but i do not
think that's the correct way of doing it. what shall be done in this
case
Andrew Thompson - 23 Apr 2007 11:11 GMT
...
>this is the code i have written

Please read my original message again, carefully.
If there is anything that I did not make clear about
helping the reader, feel free to ask.
...
>in this case if i do not return some thing even in the case of
>throwing the exception, i have to retrn some value. otherwise the
>class wont compile.

I do not quite understand what the problem is.  Your
code was almost there.  Here is an example of code
that compiles, and runs..

<sscce>
class ReportObject implements Comparable {

   int positionNumber;

   ReportObject(int positionNumber) {
       this.positionNumber = positionNumber;
   }

   public int compareTo(Object obj){
       ReportObject rObj;
       if(obj instanceof ReportObject ){
           rObj = (ReportObject)obj;

           if(this.positionNumber < rObj.getPositionNumber()){
               return -1;
           }else if(this.positionNumber == rObj.getPositionNumber()){
               return 0;
           }else if(this.positionNumber > rObj.getPositionNumber()){
               return 1;
           }

       }else{
           throw new ClassCastException(this +
               " is not comparable to " + obj );
       }
       return -2;
   }

   public int getPositionNumber() {
       return positionNumber;
   }

   public String toString() {
       return "ReportObject: " + getPositionNumber();
   }

   public static void main(String[] args) {
       ReportObject reportObject1 = new ReportObject(1);
       ReportObject reportObject2 = new ReportObject(2);
       Object object = new Object();

       try {
           System.out.println( reportObject2.compareTo(reportObject1) );
           System.out.println( reportObject1.compareTo(reportObject2) );
           System.out.println( reportObject2.compareTo(reportObject2) );
           System.out.println( reportObject2.compareTo(object) );
       } catch(ClassCastException cce) {
           System.out.println( cce.getMessage() );
       }
   }
}
</sscce>

HTH

Signature

Andrew Thompson
http://www.athompson.info/andrew/

Hendrik Maryns - 23 Apr 2007 13:48 GMT
Andrew Thompson schreef:
> ..
>> this is the code i have written
[quoted text clipped - 26 lines]
>         return -2;
>     }

Funny, I would have expected a compiler error here about unreachable
code.  The last line is unreachable, right?

Ah, no, it isn’t.  At least, the compiler cannot know: obj can be an
instance of ReportObject, and the getPositionNumber() method can vary
such that none of the inner conditions fits.

Anyway, why not simply

public int compareTo(Object obj){
   ReportObject rObj = (ReportObject)obj;
   if(this.positionNumber < rObj.getPositionNumber()){
       return -1;
   }else if(this.positionNumber == rObj.getPositionNumber()){
       return 0;
   }else if(this.positionNumber > rObj.getPositionNumber()){
       return 1;
   }
}

The JVM will throw the ClassCastException, no need to do that yourself.

And oh yes, you might try to venture into generics, in which case the
problem will go away all by itself:

class ReportObject implements Comparable<? super ReportObject> {

...

public int compareTo(ReportObject obj){
   if(this.positionNumber < obj.getPositionNumber()){
       return -1;
   }else if(this.positionNumber == obj.getPositionNumber()){
       return 0;
   }else if(this.positionNumber > obj.getPositionNumber()){
       return 1;
   }
}

...

}

H.
- --
Hendrik Maryns
http://tcl.sfs.uni-tuebingen.de/~hendrik/
==================
http://aouw.org
Ask smart questions, get good answers:
http://www.catb.org/~esr/faqs/smart-questions.html
Daniel Pitts - 23 Apr 2007 16:24 GMT
On Apr 23, 5:48 am, Hendrik Maryns <hendrik_mar...@despammed.com>
wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
[quoted text clipped - 76 lines]
>
> }

You might ALSO venture into using some basic logic.

if (a < b) {
  return -1;
} else if (a > b) {
  return 1;
}
return 0;

it is highly (100%) likely that if (!(a < b) && !(a > b)), then a ==
b.  At least with primitive data types in Java.
Daniel Pitts - 23 Apr 2007 16:28 GMT
> On Apr 23, 5:48 am, Hendrik Maryns <hendrik_mar...@despammed.com>
> wrote:
[quoted text clipped - 91 lines]
> it is highly (100%) likely that if (!(a < b) && !(a > b)), then a ==
> b.  At least with primitive data types in Java.

Actually, I think I'm wrong.
NaN isn't == NaN, is it?
In any case, comparable should throw an exception in that case too, as
you can't order NaN.
Actually, if you are using floating point values, you can use
Double.compareTo or Float.compareTo.

Indeed, I would probably do this:

public int compareTo(ReportObject obj) {
  return Integer.compareTo(this.positionNumber,
obj.getPositionNumber());
}


Free Magazines

Get these publications absolutely FREE for up to 12 months. There are no hidden fees and no obligation. Simply choose a title, complete the application form and submit it. Read more ...

Oracle MagazineNetwork ComputingComputer WorldBio-IT WorldeWeekInformation WeekInfosecurity
 
Sign In
Join
My Latest Posts
My Monitored Threads
My Blog
My Photo Gallery
My Profile
My Homepage

Start New Thread
Enable EMail Alerts
Rate this Thread



©2009 Advenet LLC   Privacy Policy - Terms of Use
This website includes both content owned or controlled by Advenet as well as content owned or controlled by third parties.