Home | Contact Us | FAQ | Search & Site Map | Link to Us
Sign In | Join | Other 45 Sites in Network
HomeAnnouncementsWhite Papers
Discussion GroupsFirst AidDatabasesJavaBeansGUIJava 3DVirtual MachineCORBASecurityToolsGeneral
Java DirectoryOpen Source ProjectsSample Book ChaptersUser GroupsWeb Resources
Related Topics
Databases.NETMore Topics ...

Java Forum / General / November 2006

Tip: Looking for answers? Try searching our database.

servlet - file upload problem...  IndexOutOfBoundsException

Thread view: 
tiewknvc9 - 01 Nov 2006 08:17 GMT
Hi,

Im trying to allow a user to upload a file ( 0 - 1 meg).  However when
the file gets larger than about 3k, its throwing an
IndexOutOfBoundsException.

Its odd that it works perfectly with extremely small files, yet breaks
on still very small files.  What is the deal?

I gave the code below (mostly taken from sample code found on the web),
Im lost, please help!  Im sure its something simple,,, simply
irritating!

Thank you so much in advance!

---------

    private void doStuff(PrintWriter out, String strContentType,
            ServletInputStream disRequest, int iContentLength){

        String strFileString = "";

        String contentType = strContentType;
        if ((contentType != null) &&
(contentType.indexOf("multipart/form-data") >= 0)) {
            DataInputStream in = new DataInputStream(disRequest);
            int formDataLength = iContentLength;

            byte dataBytes[] = new byte[formDataLength];
            int byteRead = 0;
            int totalBytesRead = 0;
            while (totalBytesRead < formDataLength) {
                try{
                    byteRead = in.read(dataBytes, totalBytesRead, formDataLength -
totalBytesRead);
                    totalBytesRead += byteRead;
                }catch(IOException ioe){
                    out.println("IOException:  ERROR analyzing file.  Error
Code:en3kd");
                }
            }

            String file = new String(dataBytes);
            strFileString = file.substring(file.indexOf("filename=\"") + 10);
            strFileString = strFileString.substring(0,
strFileString.indexOf("\n"));
            strFileString =
strFileString.substring(strFileString.lastIndexOf("\\") +
1,strFileString.indexOf("\""));

            int lastIndex = contentType.lastIndexOf("=");
            String boundary = contentType.substring(lastIndex +
1,contentType.length());

            int pos;
            pos = file.indexOf("filename=\"");
            pos = file.indexOf("\n", pos) + 1;
            pos = file.indexOf("\n", pos) + 1;
            pos = file.indexOf("\n", pos) + 1;

            int boundaryLocation = file.indexOf(boundary, pos) - 4;
            int startPos = ((file.substring(0, pos)).getBytes()).length;
            int endPos = ((file.substring(0,
boundaryLocation)).getBytes()).length;

            String strTheirFileName = strFileString;
            strFileString = "/tmp/" + strFileString;

            boolean bVtEnding = false;
            if (strFileString.endsWith("vt")){
                //good, continue
                bVtEnding = true;
            }else{
                //bad, exit
                out.println("You can only finalize unfinalized VideoTagger
files.");
                out.flush();
            }

            if (bVtEnding){
                File filOld = null;
                try{
                    filOld = new File(strFileString);
                    filOld.createNewFile();
                    FileOutputStream fos = new FileOutputStream(filOld);
                    //breaks on this line.  :(
                    fos.write(dataBytes, startPos, (endPos - startPos));
                    fos.flush();
                    fos.close();
                }catch(FileNotFoundException fnfe){
                    out.println("FileNotFoundException: <b>Error</b>, could not find
upload file...  Error Code:md9ww");
                    out.println("<b>ERROR</b>");
                }catch(IOException ioe){
                    out.println("IOException:  ERROR analyzing file...  <b>Error</b>
Code:pl1nm  " + strFileString + "<br><br>" +
ioe.getLocalizedMessage());
                    out.println("<b>ERROR</b>");
                }//catch(IndexOutOfBoundsException iobe){
                //    out.println("IndexOutOfBoundsException:  <b>ERROR</b> analyzing
file...   Error Code:ne8ni<br>");
                //    out.println("<b>ERROR</b>");
                //    iobe.printStackTrace();                           
                //}
}
}
Manish Pandit - 01 Nov 2006 08:43 GMT
Your best bet will be to use Apache File Upload API
(http://jakarta.apache.org/commons/fileupload/) instead of
programatically extracting filenames and other information by using
string operations left and right.

I believe somewhere in your code there is a substring() happening that
exceeds the string size, leading to an ArrayIndexOutOfBoundsException -
pretty much like "Hello".substring(8,5).

Apache File Upload is simpler to use and the API will provide you the
file names, size, etc.

-cheers,
Manish
Lew - 04 Nov 2006 15:32 GMT
 ---------
>     private void doStuff(PrintWriter out, String strContentType,
>             ServletInputStream disRequest, int iContentLength){
>
>         String strFileString = "";

Eliminate the type prefixes on your variables.

- Lew


Free Magazines

Get these publications absolutely FREE for up to 12 months. There are no hidden fees and no obligation. Simply choose a title, complete the application form and submit it. Read more ...

Oracle MagazineNetwork ComputingComputer WorldBio-IT WorldeWeekInformation WeekInfosecurity
 
Sign In
Join
My Latest Posts
My Monitored Threads
My Blog
My Photo Gallery
My Profile
My Homepage

Start New Thread
Enable EMail Alerts
Rate this Thread



©2008 Advenet LLC   Privacy Policy - Terms of Use
This website includes both content owned or controlled by Advenet as well as content owned or controlled by third parties.