Unlike C and C++ Java's enums are /not/ a way to give more readable names to
integer values.  They are objects (with -- like all objects -- their own
behaviour suited to whatever tasks they will be asked to perform).  You should
make up your mind whether you want to work with integer values (as returned by
your original routine) or with objects.

If you want to work with integers, then just define "public static final int"
constants for the possible values, and use those names.

If you want to use objects to represent the return values (whether you use
Java's enum objects, or some other kind of object) then you'll have to have a
step somewhere where you write code to convert from one to the other.   Note
that if you are using objects then it is not at all clear that they /have/ to
"know" what numerical return value they stand for (it may be useful, but I
don't see a really convincing need for it).  The kinds of things they need to
know might include stuff like "do I represent a fatal error ?"  "how should I
represent myself in human-readable form", and so on.

   -- chis

qu0ll schreef:

Given the situation, I think the switch statement is the way to go.

H.

IMHO there are neater solutions:

package enums;

public enum ReturnValue {

    POSITIVE, NEGATIVE, EITHER, UNDEFINED;

    public static ReturnValue convert1( int i ) {
        for ( ReturnValue current : values() ) {
            if ( current.ordinal() == i ) {
                return current;
            }
        }

        return UNDEFINED;
    }

    public static ReturnValue convert2( int i ) {
        return values()[i];
    }

    public static ReturnValue convert3( int i ) {
        try {
            return values()[i];
        } catch ( ArrayIndexOutOfBoundsException e ) {
            return UNDEFINED;
        }
    }

    public static ReturnValue convert4( int i ) {
        final ReturnValue[] v = values();
        return i >= 0 && i < v.length ? v[i] : UNDEFINED;
    }
}

- no explicit int needed, enum comes with ordinal() already
- less complex conversion

Kind regards

    robert