what's the preferred way?
JMenuBar menuBar = new JMenuBar();
JMenu menu = new JMenu(...);
menuBar.add(menu);
JMenu menu1 = new JMenu(...);
menuBar.add(menu1);
OR
JMenu menu = new JMenu(...);
JMenu menu1 = new JMenu(...);
JMenuBar menuBar = new JMenuBar();
menuBar.add(menu);
menuBar.add(menu1);
Chris Smith - 23 Mar 2005 03:03 GMT
> what's the preferred way?
>
[quoted text clipped - 15 lines]
> menuBar.add(menu);
> menuBar.add(menu1);
It's entirely up to you. If you insist on a guideline, it's generally
to minimize the average space (in lines) between the first and last use
of a variable. That seems to recommend the latter. If your menus are
very complicated the following is also nice, and ends up improving even
more:
private JMenuBar buildMenuBar()
{
JMenuBar menuBar = new JMenuBar();
menuBar.add(buildFileMenu());
menuBar.add(buildEditMenu());
return menuBar;
}
private JMenu buildFileMenu()
{
JMenu menu = new JMenu("File");
...
return menu;
}
...

Signature
www.designacourse.com
The Easiest Way To Train Anyone... Anywhere.
Chris Smith - Lead Software Developer/Technical Trainer
MindIQ Corporation
Marcin Grunwald - 23 Mar 2005 11:30 GMT
> what's the preferred way?
>
[quoted text clipped - 15 lines]
> menuBar.add(menu);
> menuBar.add(menu1);
I prefere:
JMenuBar menuBar = new JMenuBar();
createMenu(menuBar);
createMenu1(menuBar);
private JMenu createMenu(JMenuBar menuBar) {
JMenu menu = new JMenu(...);
...
menuBar.add(menu);
return menu;
}
private JMenu createMenu1(JMenuBar menuBar) {
JMenu menu = new JMenu(...);
...
menuBar.add(menu);
return menu;
}
--
Cheers
grundig